linux-kernel - Re: [RFC][PATCH] task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Mar 2021 14:33:52 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Oleg Nesterov <oleg@...hat.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        linux-kernel@...r.kernel.org, adobriyan@...il.com,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [RFC][PATCH] task_struct::state frobbing

On Thu, 25 Mar 2021 19:11:37 +0100
Peter Zijlstra <peterz@...radead.org> wrote:

> diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c
> index 5a3b65a6eb4f..17ee771e0051 100644
> --- a/drivers/net/ethernet/qualcomm/qca_spi.c
> +++ b/drivers/net/ethernet/qualcomm/qca_spi.c
> @@ -653,8 +653,7 @@ qcaspi_intr_handler(int irq, void *data)
>  	struct qcaspi *qca = data;
>  
>  	qca->intr_req++;
> -	if (qca->spi_thread &&
> -	    qca->spi_thread->state != TASK_RUNNING)
> +	if (qca->spi_thread)
>  		wake_up_process(qca->spi_thread);
>  
>  	return IRQ_HANDLED;
> @@ -777,8 +776,7 @@ qcaspi_netdev_xmit(struct sk_buff *skb, struct net_device *dev)
>  
>  	netif_trans_update(dev);
>  
> -	if (qca->spi_thread &&
> -	    qca->spi_thread->state != TASK_RUNNING)
> +	if (qca->spi_thread)
>  		wake_up_process(qca->spi_thread);
>  
>  	return NETDEV_TX_OK;

I would break out the above changes (and the like) into a separate patch,
as it's changing the logic that doesn't match what the change log is doing.

That is, I would make all the changes that doesn't care about what the
state variable is (that is, removing the reference to it) first. Then do
the type change in a later patch.

-- Steve