linux-kernel - Re: [PATCH 2/2] dt-binding: leds: Document leds-multi-gpio bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210325184140.GA16039@duo.ucw.cz>
Date:   Thu, 25 Mar 2021 19:41:40 +0100
From:   Pavel Machek <pavel@....cz>
To:     Vesa Jääskeläinen <dachaac@...il.com>
Cc:     Hermes Zhang <chenhui.zhang@...s.com>, dmurphy@...com,
        robh+dt@...nel.org, linux-leds@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        chenhuiz@...s.com, lkml@...s.com, kernel@...s.com
Subject: Re: [PATCH 2/2] dt-binding: leds: Document leds-multi-gpio bindings

Hi!

> See below.

Please trim.

> > +  led-gpios:
> > +    description: Array of one or more GPIOs pins used to control the LED.
> > +    minItems: 1
> > +    maxItems: 8  # Should be enough
> 
> We also have a case with multi color LEDs (which is probably a more common
> than multi intensity LED. So I am wondering how these both could co-exist.
> 
> From: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/leds/leds-gpio.yaml?h=v5.12-rc4#n58
> 
>         led-0 {
>             gpios = <&mcu_pio 0 GPIO_ACTIVE_LOW>;
>             linux,default-trigger = "disk-activity";
>             function = LED_FUNCTION_DISK;
>         };
> 
> Now 'gpios' (and in LED context) and 'led-gpios' is very close to each other
> and could easily be confused.
> 
> Perhaps this could be something like:
> 
> intensity-gpios = ...
> 
> or even simplified then just to gpios = <...>

...
> How would this sound?

Well, not too bad on a quick look.

Are you willing to implement such multi-color-multi-bit-multi-gpio
driver?

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)