linux-kernel - Sudden poweroffs when idle on ThinkPad x290s since v5.10-rc1 (bisected to 7c33e3c4c79a)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87tuozm3k3.fsf@gnu.org>
Date:   Thu, 25 Mar 2021 20:33:16 +0100
From:   Marius Bakke <marius@....org>
To:     ricky_wu@...ltek.com
Cc:     arnd@...db.de, bhelgaas@...gle.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
        puranjay12@...il.com, rui_feng@...lsil.com.cn,
        ulf.hansson@...aro.org, vailbhavgupta40@...ail.com
Subject: Sudden poweroffs when idle on ThinkPad x290s since v5.10-rc1
 (bisected to 7c33e3c4c79a)

Hello,

After updating to the 5.10 kernel, my laptop will spontaneously poweroff
when idle after some time (between 30 minutes and three days).

I have bisected it down to a rtsx driver update in 7c33e3c4c79a:

commit 7c33e3c4c79ac5def79e7c773e38a7113eb14204
Author: Ricky Wu <ricky_wu@...ltek.com>
Date:   Mon Sep 7 18:07:31 2020 +0800

    misc: rtsx: Add power saving functions and fix driving parameter
    
    v4:
    split power down flow and power saving function to two patch
    
    v5:
    fix up modified change under the --- line
    
    Add rts522a L1 sub-state support
    Save more power on rts5227 rts5249 rts525a rts5260
    Fix rts5260 driving parameter
    
    Signed-off-by: Ricky Wu <ricky_wu@...ltek.com>
    Link: https://lore.kernel.org/r/20200907100731.7722-1-ricky_wu@realtek.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

 drivers/misc/cardreader/rts5227.c  | 112 +++++++++++++++++++++++++++-
 drivers/misc/cardreader/rts5249.c  | 145 ++++++++++++++++++++++++++++++++++++-
 drivers/misc/cardreader/rts5260.c  |  28 +++----
 drivers/misc/cardreader/rtsx_pcr.h |  17 +++++
 4 files changed, 283 insertions(+), 19 deletions(-)

(See also <https://bugzilla.kernel.org/show_bug.cgi?id=211809>.)

I'm not sure whether this is a driver or hardware problem and am seeking
feedback on how to further debug the issue.

FWIW the problem does not seem to reproduce on an AMD ThinkPad T14 Gen 1
with the same RTS522A PCIe card reader (on stock Arch 5.10.16 kernel).

Thanks & happy hacking,
Marius

Download attachment "signature.asc" of type "application/pgp-signature" (248 bytes)