linux-kernel - Re: [PATCH v2 0/2] xen/x86: alternative fix for XSA-369

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 25 Mar 2021 18:56:57 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Roger Pau Monne <roger.pau@...rix.com>,
        linux-kernel@...r.kernel.org
Cc:     Juergen Gross <jgross@...e.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        Jan Beulich <jbeulich@...e.com>, xen-devel@...ts.xenproject.org
Subject: Re: [PATCH v2 0/2] xen/x86: alternative fix for XSA-369


On 3/24/21 7:09 PM, Boris Ostrovsky wrote:
> On 3/24/21 8:24 AM, Roger Pau Monne wrote:
>> Hello,
>>
>> This is a proposal for an alternative fix for XSA-369 that instead of
>> special casing XEN_UNPOPULATED_ALLOC to size the p2m relies on making
>> XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on the generic MEMORY_HOTPLUG
>> option rather than XEN_BALLOON_MEMORY_HOTPLUG.
>>
>> I think this is safer, as we don't want to be special casing any option
>> that pulls in generic MEMORY_HOTPLUG without XEN_BALLOON_MEMORY_HOTPLUG.
>> Without this we would also need to at least special case ZONE_DEVICE
>> which also relies on MEMORY_HOTPLUG, and is what pulls the generic
>> MEMORY_HOTPLUG option even when XEN_BALLOON_MEMORY_HOTPLUG is disabled
>> with XEN_UNPOPULATED_ALLOC.
>>
>> Thanks, Roger.
>>
>> Roger Pau Monne (2):
>>   xen/x86: make XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on
>>     MEMORY_HOTPLUG
>>   Revert "xen: fix p2m size in dom0 for disabled memory hotplug case"
>>
>>  arch/x86/include/asm/xen/page.h | 12 ------------
>>  arch/x86/xen/p2m.c              |  7 ++-----
>>  arch/x86/xen/setup.c            | 16 ++++++++++++++--
>>  drivers/xen/Kconfig             |  4 ++--
>>  4 files changed, 18 insertions(+), 21 deletions(-)
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>


Applied to for-linus-5.12b.


-boris