linux-kernel - Re: [PATCH] btrfs: fixed rudimentary typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Mar 2021 05:25:39 +0530
From:   Bhaskar Chowdhury <unixbhaskar@...il.com>
To:     dsterba@...e.cz, clm@...com, josef@...icpanda.com,
        dsterba@...e.com, linux-btrfs@...r.kernel.org,
        linux-kernel@...r.kernel.org, rdunlap@...radead.org
Subject: Re: [PATCH] btrfs: fixed rudimentary typos

On 22:47 Thu 25 Mar 2021, David Sterba wrote:
>On Thu, Mar 25, 2021 at 11:40:04PM +0530, Bhaskar Chowdhury wrote:
>> On 13:49 Thu 25 Mar 2021, David Sterba wrote:
>> >On Thu, Mar 25, 2021 at 09:51:13AM +0530, Bhaskar Chowdhury wrote:
>> >>
>> >> s/contaning/containing
>> >> s/clearning/clearing/
>> >
>> >Have hou scanned the whole subdirectory for typos? We do typo fixing
>> >about once a year in one big patch and won't fix them one by one.
>>
>> Once a year???? You must be kidding! that is not good whatever the workflow
>> you have .
>
>No kidding. It's even worse, we get that every two years.
>
>* 2016 0132761017e012ab4dc8584d679503f2ba26ca86
>  33 files changed, 106 insertions(+), 105 deletions(-)
>
>* 2018 52042d8e82ff50d40e76a275ac0b97aa663328b0
>  25 files changed, 70 insertions(+), 69 deletions(-)
>
>You can see the diffstat touches nearly all the files, almost hundred of
>fixed typos per patch. Now compare that to sending 70-100 individual
>patches. Time spent on any patch is not zero and for such trivial
>changes it's not justified so the workflow is to do that in batches.
>If you care about fixing typos in fs/btrfs/, please fix them all. I've
>found about 50.

I certainly do , not only for btrfs but for the whole kernel, it might sound
ridiculous , but someone has to bell the cat , right?

If I get little cooperation from everyone , we can pull it through, it would
be good for the future generation.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)