linux-kernel - Re: [PATCH 1/2] extcon: extcon-gpio: Log error if work-queue init fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b465d250-3933-91ce-a686-f158ca3d0a53@samsung.com>
Date:   Thu, 25 Mar 2021 09:49:57 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>,
        "hdegoede@...hat.com" <hdegoede@...hat.com>
Cc:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "sre@...nel.org" <sre@...nel.org>,
        "myungjoo.ham@...sung.com" <myungjoo.ham@...sung.com>,
        "wens@...e.org" <wens@...e.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] extcon: extcon-gpio: Log error if work-queue init
 fails

On 3/24/21 6:51 PM, Vaittinen, Matti wrote:
> Hello Hans, Chanwoo, Greg,
> 
> On Wed, 2021-03-24 at 10:25 +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 3/24/21 10:21 AM, Matti Vaittinen wrote:
>>> Add error print for probe failure when resource managed work-queue
>>> initialization fails.
>>>
>>> Signed-off-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
>>> Suggested-by: Chanwoo Choi <cw00.choi@...sung.com>
>>> ---
>>>  drivers/extcon/extcon-gpio.c | 4 +++-
>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-
>>> gpio.c
>>> index 4105df74f2b0..8ea2cda8f7f3 100644
>>> --- a/drivers/extcon/extcon-gpio.c
>>> +++ b/drivers/extcon/extcon-gpio.c
>>> @@ -114,8 +114,10 @@ static int gpio_extcon_probe(struct
>>> platform_device *pdev)
>>>  		return ret;
>>>  
>>>  	ret = devm_delayed_work_autocancel(dev, &data->work,
>>> gpio_extcon_work);
>>> -	if (ret)
>>> +	if (ret) {
>>> +		dev_err(dev, "Failed to initialize delayed_work");
>>>  		return ret;
>>> +	}
>>
>> The only ret which we can have here is -ENOMEM and as a rule we don't
>> log
>> errors for those, because the kernel memory-management code already
>> complains
>> loudly when this happens.
> 
> I know. This is why I originally omitted the print. Besides, if the
> memory is so low that devres adding fails - then we probably have
> plenty of other complaints as well... But as Chanwoo maintains the
> driver and wanted to have the print - I do not have objections to that
> either. Maybe someone some-day adds another error path to wq
> initialization in which case seeing it failed could make sense.
> 
>> So IMHO this patch should be dropped.
> Fine for me - as well as keeping it. I have no strong opinion on this.

If it is the same handling way for -ENOMEM, don't need to add log ss Hans said. 
Thanks for Hans.

> 
> Br,
> 	Matti
> 


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics