linux-kernel - Re: [PATCH 2/8] cxl/mem: Introduce 'struct cxl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210325081555.GA2983117@infradead.org>
Date:   Thu, 25 Mar 2021 08:15:55 +0000
From:   Christoph Hellwig <hch@...radead.org>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     linux-cxl@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-acpi@...r.kernel.org, ira.weiny@...el.com,
        vishal.l.verma@...el.com, alison.schofield@...el.com,
        ben.widawsky@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/8] cxl/mem: Introduce 'struct cxl_regs'

On Wed, Mar 24, 2021 at 02:30:35PM -0700, Dan Williams wrote:
> In preparation for common register mapping facility, introduce a generic
> container, 'struct cxl_regs', for CXL device register and later
> component register block base pointers. Some CXL device types implement
> both.

The code looks like complete gibberish to me with a struct of a union of
a struct declaring members in a macro.  This needs a much more detailed
explanation and rationale.