linux-kernel - [PATCH -next] staging: rtl8723bs: core: fix error return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Mar 2021 16:30:41 +0800
From:   Xu Jia <xujia39@...wei.com>
To:     <gregkh@...uxfoundation.org>, <ross.schm.dev@...il.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-staging@...ts.linux.dev>,
        <hulkcommits@...wei.com>
Subject: [PATCH -next] staging: rtl8723bs: core: fix error return

Function rtw_init_bcmc_stainfo() is always return success.
Variable 'ret' set but not used.

Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Xu Jia <xujia39@...wei.com>
---
 drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
index f96dd0b40e04..7b578192adf5 100644
--- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
+++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
@@ -551,7 +551,7 @@ u32 rtw_init_bcmc_stainfo(struct adapter *padapter)
 	psta->mac_id = 1;
 
 exit:
-	return _SUCCESS;
+	return res;
 }
 
 struct sta_info *rtw_get_bcmc_stainfo(struct adapter *padapter)
-- 
2.25.1