linux-kernel - Re: [PATCH] drivers: gpu: drm: Remove duplicate declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YFxSJ/EQWilHfT51@pendragon.ideasonboard.com>
Date:   Thu, 25 Mar 2021 11:04:39 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Tomi Valkeinen <tomba@...nel.org>, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Sebastian Reichel <sebastian.reichel@...labora.com>,
        Jyri Sarha <jsarha@...com>, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, kael_w@...h.net
Subject: Re: [PATCH] drivers: gpu: drm: Remove duplicate declaration

Hi Wan,

Thank you for the patch.

On Thu, Mar 25, 2021 at 12:50:19PM +0800, Wan Jiabing wrote:
> struct dss_device has been declared at 51st line. 
> Remove the duplicate.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
>  drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> index a40abeafd2e9..2658aadee09a 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -52,7 +52,6 @@ struct dss_device;
>  struct omap_drm_private;
>  struct omap_dss_device;
>  struct dispc_device;
> -struct dss_device;
>  struct dss_lcd_mgr_config;
>  struct snd_aes_iec958;
>  struct snd_cea_861_aud_if;

While at it, could you sort these forward declarations alphabetically,
so that duplicates are easier to see ?

-- 
Regards,

Laurent Pinchart