linux-kernel - RE: [RFC 2/7] ath10k: Add support to process rx packet in thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <003701d7215b$a44ae030$ece0a090$@codeaurora.org>
Date:   Thu, 25 Mar 2021 15:15:44 +0530
From:   "Rakesh Pillai" <pillair@...eaurora.org>
To:     "'Felix Fietkau'" <nbd@....name>,
        "'Ben Greear'" <greearb@...delatech.com>,
        "'Brian Norris'" <briannorris@...omium.org>
Cc:     "'Johannes Berg'" <johannes@...solutions.net>,
        "'Rajkumar Manoharan'" <rmanohar@...eaurora.org>,
        "'ath10k'" <ath10k@...ts.infradead.org>,
        "'linux-wireless'" <linux-wireless@...r.kernel.org>,
        "'Linux Kernel'" <linux-kernel@...r.kernel.org>,
        "'Kalle Valo'" <kvalo@...eaurora.org>,
        "'David S. Miller'" <davem@...emloft.net>,
        "'Jakub Kicinski'" <kuba@...nel.org>, <netdev@...r.kernel.org>,
        "'Doug Anderson'" <dianders@...omium.org>,
        "'Evan Green'" <evgreen@...omium.org>
Subject: RE: [RFC 2/7] ath10k: Add support to process rx packet in thread



> -----Original Message-----
> From: Felix Fietkau <nbd@....name>
> Sent: Tuesday, March 23, 2021 1:16 PM
> To: Ben Greear <greearb@...delatech.com>; Brian Norris
> <briannorris@...omium.org>
> Cc: Johannes Berg <johannes@...solutions.net>; Rajkumar Manoharan
> <rmanohar@...eaurora.org>; Rakesh Pillai <pillair@...eaurora.org>; ath10k
> <ath10k@...ts.infradead.org>; linux-wireless <linux-
> wireless@...r.kernel.org>; Linux Kernel <linux-kernel@...r.kernel.org>;
> Kalle Valo <kvalo@...eaurora.org>; David S. Miller
> <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>;
> netdev@...r.kernel.org; Doug Anderson <dianders@...omium.org>; Evan
> Green <evgreen@...omium.org>
> Subject: Re: [RFC 2/7] ath10k: Add support to process rx packet in thread
> 
> 
> On 2021-03-23 04:01, Ben Greear wrote:
> > On 3/22/21 6:20 PM, Brian Norris wrote:
> >> On Mon, Mar 22, 2021 at 4:58 PM Ben Greear
> <greearb@...delatech.com> wrote:
> >>> On 7/22/20 6:00 AM, Felix Fietkau wrote:
> >>>> On 2020-07-22 14:55, Johannes Berg wrote:
> >>>>> On Wed, 2020-07-22 at 14:27 +0200, Felix Fietkau wrote:
> >>>>>
> >>>>>> I'm considering testing a different approach (with mt76 initially):
> >>>>>> - Add a mac80211 rx function that puts processed skbs into a list
> >>>>>> instead of handing them to the network stack directly.
> >>>>>
> >>>>> Would this be *after* all the mac80211 processing, i.e. in place of the
> >>>>> rx-up-to-stack?
> >>>> Yes, it would run all the rx handlers normally and then put the
> >>>> resulting skbs into a list instead of calling netif_receive_skb or
> >>>> napi_gro_frags.
> >>>
> >>> Whatever came of this?  I realized I'm running Felix's patch since his mt76
> >>> driver needs it.  Any chance it will go upstream?
> >>
> >> If you're asking about $subject (moving NAPI/RX to a thread), this
> >> landed upstream recently:
> >> http://git.kernel.org/linus/adbb4fb028452b1b0488a1a7b66ab856cdf20715
> >>
> >> It needs a bit of coaxing to work on a WiFi driver (including: WiFi
> >> drivers tend to have a different netdev for NAPI than they expose to
> >> /sys/class/net/), but it's there.
> >>
> >> I'm not sure if people had something else in mind in the stuff you're
> >> quoting though.
> >
> > No, I got it confused with something Felix did:
> >
> > https://github.com/greearb/mt76/blob/master/patches/0001-net-add-
> support-for-threaded-NAPI-polling.patch
> >
> > Maybe the NAPI/RX to a thread thing superceded Felix's patch?
> Yes, it did and it's in linux-next already.
> I sent the following change to make mt76 use it:
> https://github.com/nbd168/wireless/commit/1d4ff31437e5aaa999bd7a

Hi Felix / Ben,

In case of ath10k (snoc based targets), we have a lot of processing in the NAPI context.
Even moving this to threaded NAPI is not helping much due to the load.

Breaking the tasks into multiple context (with the patch series I posted) is helping in improving the throughput.
With the current rx_thread based approach, the rx processing is broken into two parallel contexts
1) reaping the packets from the HW
2) processing these packets list and handing it over to mac80211 (and later to the network stack)

This is the primary reason for choosing the rx thread approach.

Thanks,
Rakesh.

> 
> - Felix