linux-kernel - Re: [PATCH v5 9/9] dt-bindings: serial: stm32: Use 'type: object' instead of false for 'additionalProperties'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <068cb7ae-9afc-606d-2579-189e46516cd5@foss.st.com>
Date:   Thu, 25 Mar 2021 11:12:21 +0000
From:   Valentin CARON - foss <valentin.caron@...s.st.com>
To:     "dillon.minfei@...il.com" <dillon.minfei@...il.com>,
        "robh@...nel.org" <robh@...nel.org>,
        Alexandre TORGUE - foss <alexandre.torgue@...s.st.com>,
        "rong.a.chen@...el.com" <rong.a.chen@...el.com>,
        "a.fatoum@...gutronix.de" <a.fatoum@...gutronix.de>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "vladimir.murzin@....com" <vladimir.murzin@....com>,
        "afzal.mohd.ma@...il.com" <afzal.mohd.ma@...il.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "Erwan LE-RAY - foss" <erwan.leray@...s.st.com>,
        Erwan LE RAY <erwan.leray@...com>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "lkp@...el.com" <lkp@...el.com>
Subject: Re: [PATCH v5 9/9] dt-bindings: serial: stm32: Use 'type: object'
 instead of false for 'additionalProperties'

Hi Dillon,

It's okay for me.

Regards,

Valentin

On 3/25/21 7:19 AM, dillon.minfei@...il.com wrote:
> From: dillon min <dillon.minfei@...il.com>
>
> To use additional properties 'bluetooth' on serial, need replace false with
> 'type: object' for 'additionalProperties' to make it as a node, else will
> run into dtbs_check warnings.
>
> 'arch/arm/boot/dts/stm32h750i-art-pi.dt.yaml: serial@...04800:
> 'bluetooth' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Fixes: af1c2d81695b ("dt-bindings: serial: Convert STM32 UART to json-schema")
> Reported-by: kernel test robot <lkp@...el.com>
> Tested-by: Valentin Caron <valentin.caron@...s.st.com>
> Signed-off-by: dillon min <dillon.minfei@...il.com>
> ---
>
> v5: accroding to rob's suggestion, replace false with 'type: object'
>      of 'additionalProperties'.
>
>   Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> index 8631678283f9..865be05083c3 100644
> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> @@ -80,7 +80,8 @@ required:
>     - interrupts
>     - clocks
>   
> -additionalProperties: false
> +additionalProperties:
> +  type: object
>   
>   examples:
>     - |