linux-kernel - Re: [PATCH] mm/sparse: Add the missing sparse_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f20f644-9f51-5f0b-a162-c340912b5212@redhat.com>
Date:   Thu, 25 Mar 2021 13:45:13 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Wang Wensheng <wangwensheng4@...wei.com>,
        akpm@...ux-foundation.org, osalvador@...e.de,
        pasha.tatashin@...cle.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Cc:     rui.xiang@...wei.com
Subject: Re: [PATCH] mm/sparse: Add the missing sparse_buffer_fini() in error
 branch

On 25.03.21 12:31, Wang Wensheng wrote:
> sparse_buffer_init() and sparse_buffer_fini() should appear in pair, or
> a WARN issue would be through the next time sparse_buffer_init() runs.
> 
> Add the missing sparse_buffer_fini() in error branch.
> 
> Fixes: 85c77f791390 ("mm/sparse: add new sparse_init_nid() and sparse_init()")
> Signed-off-by: Wang Wensheng <wangwensheng4@...wei.com>
> ---
>   mm/sparse.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/mm/sparse.c b/mm/sparse.c
> index 7bd23f9..33406ea 100644
> --- a/mm/sparse.c
> +++ b/mm/sparse.c
> @@ -547,6 +547,7 @@ static void __init sparse_init_nid(int nid, unsigned long pnum_begin,
>   			pr_err("%s: node[%d] memory map backing failed. Some memory will not be available.",
>   			       __func__, nid);
>   			pnum_begin = pnum;
> +			sparse_buffer_fini();
>   			goto failed;
>   		}
>   		check_usemap_section_nr(nid, usage);
> 

Did you actually manage to reproduce this? I would have thought that 
__populate_section_memmap() barely fails during boot ...


Anyhow, looks like the right think to do to me

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb