linux-kernel - Re: [PATCH] tools: perf: Remove duplicate includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YFyJDCk/S+el4SDi@kernel.org>
Date:   Thu, 25 Mar 2021 09:58:52 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org, kael_w@...h.net
Subject: Re: [PATCH] tools: perf: Remove duplicate includes

Em Tue, Mar 23, 2021 at 01:01:39PM +0800, Wan Jiabing escreveu:
> sys/stat.h has been included at line 23, so remove the
> duplicate one at line 27.
> linux/string.h has been included at line 7, so remove the
> duplicate one at line 9.
> time.h has been included at line 14, so remove the
> duplicate one at line 28.

Thanks, applied.

- Arnaldo

 
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
>  tools/perf/builtin-daemon.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/tools/perf/builtin-daemon.c b/tools/perf/builtin-daemon.c
> index ace8772a4f03..632ecd010a4f 100644
> --- a/tools/perf/builtin-daemon.c
> +++ b/tools/perf/builtin-daemon.c
> @@ -6,7 +6,6 @@
>  #include <linux/zalloc.h>
>  #include <linux/string.h>
>  #include <linux/limits.h>
> -#include <linux/string.h>
>  #include <string.h>
>  #include <sys/file.h>
>  #include <signal.h>
> @@ -24,8 +23,6 @@
>  #include <sys/signalfd.h>
>  #include <sys/wait.h>
>  #include <poll.h>
> -#include <sys/stat.h>
> -#include <time.h>
>  #include "builtin.h"
>  #include "perf.h"
>  #include "debug.h"
> -- 
> 2.25.1
> 

-- 

- Arnaldo