linux-kernel - Re: [PATCH] [v2] drivers: gpu: drm: Remove duplicate declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Mar 2021 15:05:50 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Tomi Valkeinen <tomba@...nel.org>, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Sebastian Reichel <sebastian.reichel@...labora.com>,
        Jyri Sarha <jsarha@...com>, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, kael_w@...h.net
Subject: Re: [PATCH] [v2] drivers: gpu: drm: Remove duplicate declaration

Hi Wan,

Thank you for the patch.

On Thu, Mar 25, 2021 at 07:10:24PM +0800, Wan Jiabing wrote:
> struct dss_device has been declared. Remove the duplicate.
> And sort these forward declarations alphabetically.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

Tomi, I assume you'll handle this patch, please let me know if you don't
plan to do so.

> ---
> Changelog:
> v2:
> - Sort forward declarations alphabetically.
> ---
>  drivers/gpu/drm/omapdrm/dss/omapdss.h | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> index a40abeafd2e9..040d5a3e33d6 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -48,16 +48,15 @@
>  #define DISPC_IRQ_ACBIAS_COUNT_STAT3	(1 << 29)
>  #define DISPC_IRQ_FRAMEDONE3		(1 << 30)
>  
> -struct dss_device;
> -struct omap_drm_private;
> -struct omap_dss_device;
>  struct dispc_device;
> +struct drm_connector;
>  struct dss_device;
>  struct dss_lcd_mgr_config;
> +struct hdmi_avi_infoframe;
> +struct omap_drm_private;
> +struct omap_dss_device;
>  struct snd_aes_iec958;
>  struct snd_cea_861_aud_if;
> -struct hdmi_avi_infoframe;
> -struct drm_connector;
>  
>  enum omap_display_type {
>  	OMAP_DISPLAY_TYPE_NONE		= 0,

-- 
Regards,

Laurent Pinchart