linux-kernel - Re: [PATCH] KVM: make: Fix out-of-source module builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0391f264-ff1a-5ab6-c989-96a9f28a9457@redhat.com>
Date:   Fri, 26 Mar 2021 18:36:17 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Siddharth Chandrasekaran <sidcha@...zon.de>,
        Sean Christopherson <seanjc@...gle.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: make: Fix out-of-source module builds

On 24/03/21 13:43, Siddharth Chandrasekaran wrote:
> Building kvm module out-of-source with,
> 
>      make -C $SRC O=$BIN M=arch/x86/kvm
> 
> fails to find "irq.h" as the include dir passed to cflags-y does not
> prefix the source dir. Fix this by prefixing $(srctree) to the include
> dir path.
> 
> Signed-off-by: Siddharth Chandrasekaran <sidcha@...zon.de>
> ---
>   arch/x86/kvm/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/Makefile b/arch/x86/kvm/Makefile
> index 1b4766fe1de2..eafc4d601f25 100644
> --- a/arch/x86/kvm/Makefile
> +++ b/arch/x86/kvm/Makefile
> @@ -1,6 +1,6 @@
>   # SPDX-License-Identifier: GPL-2.0
>   
> -ccflags-y += -Iarch/x86/kvm
> +ccflags-y += -I $(srctree)/arch/x86/kvm
>   ccflags-$(CONFIG_KVM_WERROR) += -Werror
>   
>   ifeq ($(CONFIG_FRAME_POINTER),y)
> 

Queued, thanks.

Paolo