linux-kernel - Re: [PATCH] usbip: vhci_hcd: do proper error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2aabe03-0cd9-fe59-5354-0596e3360402@linuxfoundation.org>
Date:   Fri, 26 Mar 2021 14:24:37 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Muhammad Usama Anjum <musamaanjum@...il.com>, shuah@...nel.org,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, valentina.manea.m@...il.com,
        stern@...land.harvard.edu, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] usbip: vhci_hcd: do proper error handling

On 3/25/21 5:46 AM, Muhammad Usama Anjum wrote:
> The driver was assuming that all the parameters would be valid. But it
> is possible that parameters are sent from userspace. For those cases,
> appropriate error checks have been added.
> 

Are you sure this change is necessary for vhci_hcd? Is there a
scenario where vhci_hcd will receive these values from userspace?

Is there a way to reproduce the problem?

thanks,
-- Shuah