linux-kernel - Re: [PATCH] [v2] arch: powerpc: Remove duplicate includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y2ea79vl.fsf@linkitivity.dja.id.au>
Date:   Fri, 26 Mar 2021 16:38:06 +1100
From:   Daniel Axtens <dja@...ens.net>
To:     Wan Jiabing <wanjiabing@...o.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Nicholas Piggin <npiggin@...il.com>,
        "Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>,
        Cédric Le Goater <clg@...d.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Wan Jiabing <wanjiabing@...o.com>,
        Ganesh Goudar <ganeshgr@...ux.ibm.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Michal Suchanek <msuchanek@...e.de>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Pingfan Liu <kernelfans@...il.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Cc:     kael_w@...h.net
Subject: Re: [PATCH] [v2] arch: powerpc: Remove duplicate includes

Wan Jiabing <wanjiabing@...o.com> writes:

> mmu-hash.h: asm/bug.h has been included at line 12, so remove 
> the duplicate one at line 21.

Looking at the file I had wondered if this was due to a #ifdef being
removed, but no, the second one was just added in commit 891121e6c02c
("powerpc/mm: Differentiate between hugetlb and THP during page
walk"). How odd!

Anyway, all of these look good to me, and the automated checks at
http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210323062916.295346-1-wanjiabing@vivo.com/
have all passed.

Reviewed-by: Daniel Axtens <dja@...ens.net>

Kind regards,
Daniel