linux-kernel - Re: [PATCH] powerpc/iommu/debug: Remove redundant NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r1k2795x.fsf@linkitivity.dja.id.au>
Date:   Fri, 26 Mar 2021 16:53:30 +1100
From:   Daniel Axtens <dja@...ens.net>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, mpe@...erman.id.au
Cc:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, paulus@...ba.org,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/iommu/debug: Remove redundant NULL check

Hi Jiapeng Chong, <jiapeng.chong@...ux.alibaba.com> writes:

> Fix the following coccicheck warnings:
>
> ./fs/io_uring.c:5989:4-9: WARNING: NULL check before some freeing
> functions is not needed.

This looks correct to me, and matches the description of debugfs_remove
in Documentation/filesystems/debugfs.rst.

If you have a number of similar fixes it might be helpful to do them in
a single bigger patch, but I'm not sure if coccicheck reports much else
as I don't have coccinelle installed at the moment.

Reviewed-by: Daniel Axtens <dja@...ens.net>

Kind regards,
Daniel