linux-kernel - Re: [PATCH] media: sq905.c: fix uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACT4Y+Y8f6-c6zYCN=d0557xEryAzBfS9n2m=vBcdjHSi5gYcw@mail.gmail.com>
Date:   Fri, 26 Mar 2021 08:14:30 +0100
From:   Dmitry Vyukov <dvyukov@...gle.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Alaa Emad <alaaemadhossney.ae@...il.com>,
        Hans Verkuil <hverkuil@...all.nl>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        syzkaller <syzkaller@...glegroups.com>,
        syzbot+a4e309017a5f3a24c7b3@...kaller.appspotmail.com
Subject: Re: [PATCH] media: sq905.c: fix uninitialized variable

On Fri, Mar 26, 2021 at 8:11 AM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Thu, Mar 25, 2021 at 11:22:02PM +0200, Alaa Emad wrote:
> > Reported-by: syzbot+a4e309017a5f3a24c7b3@...kaller.appspotmail.com
> > Signed-off-by: Alaa Emad <alaaemadhossney.ae@...il.com>
> > ---
>
> I know I do not take patches with no changelog text, but other
> maintainers might be more leniant :(

I wonder if it's the right fix or not.
Initializing variables will, of course, silence the warning, but it's
not necessarily the right fix. I suspect there is something wrong in
how ret/act_len are user/checked.