linux-kernel - Re: [PATCH -next] drivers: crypto: CRYPTO_DEV_HISI_HPRE select CRYPTO_ECC and CRYPTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Mar 2021 15:19:10 +0800
From:   yumeng <yumeng18@...wei.com>
To:     Zhang Jianhua <zhangjianhua18@...wei.com>,
        <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
        <xuzaibo@...wei.com>, <qianweili@...wei.com>,
        <yuehaibing@...wei.com>, <tanshukun1@...wei.com>,
        <sfr@...b.auug.org.au>
CC:     <linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <johnny.chenyi@...wei.com>
Subject: Re: [PATCH -next] drivers: crypto: CRYPTO_DEV_HISI_HPRE select
 CRYPTO_ECC and CRYPTO_ECDH

Thanks, there is a similar patch to yours that was sent in advance:
https://www.spinics.net/lists/linux-crypto/msg54238.html

在 2021/3/26 15:16, Zhang Jianhua 写道:
> If CRYPTO_DEV_HISI_HPRE=y, the following errors will be seen while
> building hpre_crypto.c
> 
> drivers/crypto/hisilicon/hpre/hpre_crypto.o: In function
> `hpre_curve25519_compute_value':
> hpre_crypto.c:(.text+0x151b): undefined reference to
> `ecc_get_curve25519'
> drivers/crypto/hisilicon/hpre/hpre_crypto.o: In function
> `hpre_curve25519_set_secret':
> hpre_crypto.c:(.text+0x2714): undefined reference to
> `ecc_get_curve25519'
> drivers/crypto/hisilicon/hpre/hpre_crypto.o: In function
> `hpre_ecdh_set_secret':
> hpre_crypto.c:(.text+0x27ed): undefined reference to
> `crypto_ecdh_decode_key'
> hpre_crypto.c:(.text+0x2954): undefined reference to `ecc_get_curve'
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhang Jianhua <zhangjianhua18@...wei.com>
> ---
>   drivers/crypto/hisilicon/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
> index c45adb15ce8d..d87c89af2a7f 100644
> --- a/drivers/crypto/hisilicon/Kconfig
> +++ b/drivers/crypto/hisilicon/Kconfig
> @@ -69,6 +69,8 @@ config CRYPTO_DEV_HISI_HPRE
>   	select CRYPTO_DEV_HISI_QM
>   	select CRYPTO_DH
>   	select CRYPTO_RSA
> +	select CRYPTO_ECC
> +	select CRYPTO_ECDH
>   	help
>   	  Support for HiSilicon HPRE(High Performance RSA Engine)
>   	  accelerator, which can accelerate RSA and DH algorithms.
>