linux-kernel - RE: Re: [PATCH v3 3/3] PCI: imx: clear vreg bypass when pcie vph voltage is 3v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB5853077653BBA73ACF58CF3F8C619@VI1PR04MB5853.eurprd04.prod.outlook.com>
Date:   Fri, 26 Mar 2021 07:55:34 +0000
From:   Richard Zhu <hongxing.zhu@....com>
To:     Krzysztof Wilczyński <kw@...ux.com>
CC:     "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "andrew.smirnov@...il.com" <andrew.smirnov@...il.com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "stefan@...er.ch" <stefan@...er.ch>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: RE:  Re: [PATCH v3 3/3] PCI: imx: clear vreg bypass when pcie vph
 voltage is 3v3

> -----Original Message-----
> From: Krzysztof Wilczyński <kw@...ux.com>
> Sent: Friday, March 26, 2021 3:46 PM
> To: Richard Zhu <hongxing.zhu@....com>
> Cc: l.stach@...gutronix.de; andrew.smirnov@...il.com;
> shawnguo@...nel.org; bhelgaas@...gle.com; stefan@...er.ch;
> lorenzo.pieralisi@....com; linux-pci@...r.kernel.org; dl-linux-imx
> <linux-imx@....com>; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; kernel@...gutronix.de
> Subject: Re: [PATCH v3 3/3] PCI: imx: clear vreg bypass when pcie vph
> voltage is 3v3
> Hi,
> 
> > +             /*
> > +              * Regarding to the datasheet, the PCIE_VPH is suggested
> > +              * to be 1.8V. If the PCIE_VPH is supplied by 3.3V, the
> > +              * VREG_BYPASS should be cleared to zero.
> > +              */
> [...]
> 
> A small nitpick here.  What about the following:
> 
>         Regarding the data sheet, the PCIE_VPH is suggested to be 1.8V.
>         If the PCIE_VPH is supplied with 3.3V, the VREG_BYPASS should be
>         cleared to zero.
> 
> What do you think?
[Richard Zhu] Hi Krzysztof:
Thanks for your comments. You're right.
It should be "Regarding something", not the "Regarding to something"
Thanks. 😊

Best Regards
Richard Zhu

> 
> Krzysztof