[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <85e0d0f0-e6c7-e287-c6b2-ab5d37b718e2@redhat.com>
Date: Fri, 26 Mar 2021 10:11:07 +0100
From: David Hildenbrand <david@...hat.com>
To: Wang Wensheng <wangwensheng4@...wei.com>,
akpm@...ux-foundation.org, pasha.tatashin@...cle.com,
osalvador@...e.de, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Cc: rui.xiang@...wei.com
Subject: Re: [PATCH] mm/sparse: Add the missing sparse_buffer_fini() in error
branch
On 26.03.21 03:23, Wang Wensheng wrote:
> sparse_buffer_init() and sparse_buffer_fini() should appear in pair, or
> a WARN issue would be through the next time sparse_buffer_init() runs.
>
> Add the missing sparse_buffer_fini() in error branch.
>
> Fixes: 85c77f791390 ("mm/sparse: add new sparse_init_nid() and sparse_init()")
> Signed-off-by: Wang Wensheng <wangwensheng4@...wei.com>
> ---
> mm/sparse.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/sparse.c b/mm/sparse.c
> index 7bd23f9..33406ea 100644
> --- a/mm/sparse.c
> +++ b/mm/sparse.c
> @@ -547,6 +547,7 @@ static void __init sparse_init_nid(int nid, unsigned long pnum_begin,
> pr_err("%s: node[%d] memory map backing failed. Some memory will not be available.",
> __func__, nid);
> pnum_begin = pnum;
> + sparse_buffer_fini();
> goto failed;
> }
> check_usemap_section_nr(nid, usage);
>
I am confused, why the resend, and why without RBs?
https://lkml.kernel.org/r/20210325113155.118574-1-wangwensheng4@huawei.com
--
Thanks,
David / dhildenb
Powered by blists - more mailing lists