linux-kernel - Re: [PATCH 1/1] KVM: x86: remove unused declaration of kvm_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sg4ickoh.fsf@vitty.brq.redhat.com>
Date:   Fri, 26 Mar 2021 10:45:50 +0100
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     Dongli Zhang <dongli.zhang@...cle.com>, kvm@...r.kernel.org,
        x86@...nel.org
Cc:     pbonzini@...hat.com, seanjc@...gle.com, wanpengli@...cent.com,
        jmattson@...gle.com, joro@...tes.org, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, hpa@...or.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] KVM: x86: remove unused declaration of kvm_write_tsc()

Dongli Zhang <dongli.zhang@...cle.com> writes:

> The kvm_write_tsc() was not used since commit 0c899c25d754 ("KVM: x86: do
> not attempt TSC synchronization on guest writes"). Remove its unused
> declaration.

It's not just not used, it's not present. Let me try to rephrase the
commit message a bit:

"
Commit 0c899c25d754 ("KVM: x86: do not attempt TSC synchronization on
guest writes") renamed kvm_write_tsc() to kvm_synchronize_tsc() and made
it 'static'. Remove the leftover declaration from x86.h

Fixes: 0c899c25d754 ("KVM: x86: do not attempt TSC synchronization on
guest writes")
"

The subject line should probably also get adjusted like
"KVM: x86: remove dangling declaration of kvm_write_tsc()"

>
> Signed-off-by: Dongli Zhang <dongli.zhang@...cle.com>
> ---
>  arch/x86/kvm/x86.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h
> index 39eb04887141..9035e34aa156 100644
> --- a/arch/x86/kvm/x86.h
> +++ b/arch/x86/kvm/x86.h
> @@ -250,7 +250,6 @@ static inline bool kvm_vcpu_latch_init(struct kvm_vcpu *vcpu)
>  void kvm_write_wall_clock(struct kvm *kvm, gpa_t wall_clock, int sec_hi_ofs);
>  void kvm_inject_realmode_interrupt(struct kvm_vcpu *vcpu, int irq, int inc_eip);
>  
> -void kvm_write_tsc(struct kvm_vcpu *vcpu, struct msr_data *msr);
>  u64 get_kvmclock_ns(struct kvm *kvm);
>  
>  int kvm_read_guest_virt(struct kvm_vcpu *vcpu,

-- 
Vitaly