linux-kernel - Re: [PATCH] ARM: vexpress: spc: fix uniprocessor initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210326134131.bftspszcwixrkomt@bogus>
Date:   Fri, 26 Mar 2021 13:41:31 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Sudeep Holla <sudeep.holla@....com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: vexpress: spc: fix uniprocessor initialization

Hi Arnd,

Sorry for the delay

On Tue, Mar 23, 2021 at 01:56:38PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> When CONFIG_SMP is disabled, topology_physical_package_id()
> returns -1 and gcc notices undefined behavior:
> 
> arch/arm/mach-versatile/spc.c: In function 've_spc_clk_init':
> arch/arm/mach-versatile/spc.c:583:21: error: array subscript -1 is below array bounds of 'bool[2]' {aka '_Bool[2]'} [-Werror=array-bounds]
>   583 |   if (init_opp_table[cluster])
>       |       ~~~~~~~~~~~~~~^~~~~~~~~
> arch/arm/mach-versatile/spc.c:556:7: note: while referencing 'init_opp_table'
>   556 |  bool init_opp_table[MAX_CLUSTERS] = { false };
>       |       ^~~~~~~~~~~~~~
> 
> It's not clear to me what the correct behavior should be, but
> it seems safe to just not continue with the initialization.
> 

I don't have any other patches for vexpress platform or driver support.
Can you apply this directly ? Assuming that,

Acked-by: Sudeep Holla <sudeep.holla@....com>

--
Regards,
Sudeep