linux-kernel - Re: [PATCH 14/15] staging: rtl8723bs: put parentheses on macros with complex values in include/sta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210326135700.GA1952@agape.jhs>
Date:   Fri, 26 Mar 2021 14:57:01 +0100
From:   Fabio Aiuto <fabioaiuto83@...il.com>
To:     David Laight <David.Laight@...LAB.COM>
Cc:     gregkh@...uxfoundation.org, dan.carpenter@...cle.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/15] staging: rtl8723bs:  put parentheses on macros
 with complex values in include/sta_info.h

On Fri, Mar 26, 2021 at 01:39:24PM +0000, David Laight wrote:
> From: Fabio Aiuto 
> > Sent: 26 March 2021 09:09
> > 
> > fix the following checkpatch warnings:
> > 
> > ERROR: Macros with complex values should be enclosed in parentheses
> > 284: FILE: drivers/staging/rtl8723bs/include/sta_info.h:284:
> > +#define STA_RX_PKTS_ARG(sta) \
> > --
> > ERROR: Macros with complex values should be enclosed in parentheses
> > 289: FILE: drivers/staging/rtl8723bs/include/sta_info.h:289:
> > +#define STA_LAST_RX_PKTS_ARG(sta) \
> > --
> > ERROR: Macros with complex values should be enclosed in parentheses
> > 294: FILE: drivers/staging/rtl8723bs/include/sta_info.h:294:
> > +#define STA_RX_PKTS_DIFF_ARG(sta) \
> > 
> > Signed-off-by: Fabio Aiuto <fabioaiuto83@...il.com>
> > ---
> >  drivers/staging/rtl8723bs/include/sta_info.h | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8723bs/include/sta_info.h
> > b/drivers/staging/rtl8723bs/include/sta_info.h
> > index abde3e3df988..1cdf93ec3b66 100644
> > --- a/drivers/staging/rtl8723bs/include/sta_info.h
> > +++ b/drivers/staging/rtl8723bs/include/sta_info.h
> > @@ -282,19 +282,19 @@ struct sta_info {
> >  	} while (0)
> > 
> >  #define STA_RX_PKTS_ARG(sta) \
> > -	sta->sta_stats.rx_mgnt_pkts \
> > +	(sta->sta_stats.rx_mgnt_pkts \
> >  	, sta->sta_stats.rx_ctrl_pkts \
> > -	, sta->sta_stats.rx_data_pkts
> > +	, sta->sta_stats.rx_data_pkts)
> 
> That doesn't look right at all.
> You've changed what is (probably) a list of arguments to a function
> into a comma operator list.
> 
> 	David
> 
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
> 

ops, you're right David, thank you and sorry to all
for noise.

fabio