linux-kernel - Re: [PATCH] platform/surface: clean up a variable in surface_dtx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e614021b-62aa-c879-c324-fc1dc1eec73e@gmail.com>
Date:   Fri, 26 Mar 2021 15:06:08 +0100
From:   Maximilian Luz <luzmaximilian@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <mgross@...ux.intel.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] platform/surface: clean up a variable in
 surface_dtx_read()

On 3/26/21 1:28 PM, Dan Carpenter wrote:
> The "&client->ddev->lock" and "&ddev->lock" are the same thing.  Let's
> use "&ddev->lock" consistently.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Good catch, thanks!

Reviewed-by: Maximilian Luz <luzmaximilian@...il.com>

> ---
>   drivers/platform/surface/surface_dtx.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/surface/surface_dtx.c b/drivers/platform/surface/surface_dtx.c
> index 1fedacf74050..63ce587e79e3 100644
> --- a/drivers/platform/surface/surface_dtx.c
> +++ b/drivers/platform/surface/surface_dtx.c
> @@ -487,7 +487,7 @@ static ssize_t surface_dtx_read(struct file *file, char __user *buf, size_t coun
>   			if (status < 0)
>   				return status;
>   
> -			if (down_read_killable(&client->ddev->lock))
> +			if (down_read_killable(&ddev->lock))
>   				return -ERESTARTSYS;
>   
>   			/* Need to check that we're not shut down again. */
>