linux-kernel - Re: Marvell: hw perfevents: unable to count PMU IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Mar 2021 15:34:43 +0100
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Robin Murphy <robin.murphy@....com>, Will Deacon <will@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        LKML <linux-kernel@...r.kernel.org>,
        Vadym Kochan <vadym.kochan@...ision.eu>,
        Oleksandr Mazur <oleksandr.mazur@...ision.eu>,
        Robert Marko <robert.marko@...tura.hr>
Subject: Re: Marvell: hw perfevents: unable to count PMU IRQs

Dear Robin,


Thank you for the quick reply.

Am 26.03.21 um 13:29 schrieb Robin Murphy:
> On 2021-03-25 21:39, Paul Menzel wrote:

>> On the Marvell Prestera switch, Linux 5.10.4 prints the error (with an 
>> additional info level message) below.
>>
>>      [    0.000000] Linux version 5.10.4 (robimarko@...builder9) (aarch64-linux-gnu-gcc (Debian 6.3.0-18) 6.3.0 20170516, GNU ld (GNU Binutils for Debian) 2.28) #1 SMP PREEMPT Thu Mar 11 10:22:09 UTC 2021
>>      […]
>>      [    1.996658] hw perfevents: unable to count PMU IRQs
>>      [    2.001825] hw perfevents: /ap806/config-space@...00000/pmu: failed to register PMU devices!

[…]

>> Please find the output of `dmesg` attached.
>>
>> How can the IRQs be counted?
> 
> Well, that message simply means we got an error back from 
> platform_irq_count(), which in turn implies that 
> platform_get_irq_optional() failed. Most likely we got -EPROBE_DEFER 
> back from of_irq_get() because the relevant interrupt controller wasn't 
> ready by that point - especially since that's the o9nly error code that 
> platform_irq_cont() will actually pass. It looks like that should end up 
> getting propagated all the way out appropriately, so the PMU driver 
> should defer and be able to probe OK once the mvebu-pic driver has 
> turned up to provide its IRQ. We could of course do a better job of not 
> shouting error messages for a non-fatal condition....

Yes, that would be great.

> As for why the PMU doesn't eventually show up, my best guess would be 
> either an issue with the mvebu-pic driver itself probing, and/or perhaps 
> something in fw_devlink going awry - inspecting sysfs should shed a bit 
> more light on those.

I just noticed, I missed

     [    3.298670] hw perfevents: enabled with armv8_cortex_a72 PMU 
driver, 7 counters available

a good second. So the interrupt controller indeed seems to take longer 
to be ready.

I guess, I’d need to boot with `initcall_debug` to find out the callers 
of the PMU functions.


Kind regards,

Paul