linux-kernel - Re: [PATCH v5] PCI: endpoint: Fix NULL pointer dereference for ->get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <161677217283.28772.11255664363565834754.b4-ty@arm.com>
Date:   Fri, 26 Mar 2021 15:23:08 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     linux-kernel@...r.kernel.org, Shradha Todi <shradha.t@...sung.com>,
        linux-pci@...r.kernel.org
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>, hari.tv@...sung.com,
        p.rajanbabu@...sung.com, niyas.ahmed@...sung.com,
        bhelgaas@...gle.com, pankaj.dubey@...sung.com,
        Sriram Dash <dash.sriram@...il.com>, l.mehra@...sung.com,
        kishon@...com
Subject: Re: [PATCH v5] PCI: endpoint: Fix NULL pointer dereference for ->get_features()

On Wed, 24 Mar 2021 15:46:09 +0530, Shradha Todi wrote:
> get_features ops of pci_epc_ops may return NULL, causing NULL pointer
> dereference in pci_epf_test_alloc_space function. Let us add a check for
> pci_epc_feature pointer in pci_epf_test_bind before we access it to avoid
> any such NULL pointer dereference and return -ENOTSUPP in case
> pci_epc_feature is not found.
> 
> When the patch is not applied and EPC features is not implemented in the
> platform driver, we see the following dump due to kernel NULL pointer
> dereference.
> 
> [...]

Applied to pci/endpoint, thanks!

[1/1] PCI: endpoint: Fix NULL pointer dereference for ->get_features()
      https://git.kernel.org/lpieralisi/pci/c/6613bc2301

Thanks,
Lorenzo