linux-kernel - Re: [PATCH 05/15] remove useless return statement for void function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dce63f98-9825-3204-fb0e-0e4d958bf581@huawei.com>
Date:   Sat, 27 Mar 2021 14:49:56 +0800
From:   Xiaofei Tan <tanxiaofei@...wei.com>
To:     <rjw@...ysocki.net>, <lenb@...nel.org>, <rui.zhang@...el.com>,
        <bhelgaas@...gle.com>
CC:     <linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-pci@...r.kernel.org>, <linuxarm@...neuler.org>
Subject: Re: [PATCH 05/15] remove useless return statement for void function

Oh, sorry, the title doesn't contain subsystem and module name. I'll 
send v2 later. Please ignore this one. thanks.

On 2021/3/27 14:40, Xiaofei Tan wrote:
> Remove useless return statement for void function, reported by
> checkpatch.pl.
>
> WARNING: void function return statements are not generally useful
> FILE: drivers/acpi/acpi_ipmi.c:482:
> +       return;
> +}
>
> Signed-off-by: Xiaofei Tan <tanxiaofei@...wei.com>
> ---
>  drivers/acpi/acpi_ipmi.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_ipmi.c b/drivers/acpi/acpi_ipmi.c
> index 9d6c0fc..bbd00d9 100644
> --- a/drivers/acpi/acpi_ipmi.c
> +++ b/drivers/acpi/acpi_ipmi.c
> @@ -478,7 +478,6 @@ static void ipmi_register_bmc(int iface, struct device *dev)
>  	ipmi_dev_release(ipmi_device);
>  err_ref:
>  	put_device(smi_data.dev);
> -	return;
>  }
>
>  static void ipmi_bmc_gone(int iface)
>