linux-kernel - Re: [PATCH v2] media: sq905.c: fix uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 27 Mar 2021 10:44:37 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Alaa Emad <alaaemadhossney.ae@...il.com>
Cc:     gregkh@...uxfoundation.org, mchehab@...nel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzkaller@...glegroups.com,
        syzbot+a4e309017a5f3a24c7b3@...kaller.appspotmail.com
Subject: Re: [PATCH v2] media: sq905.c: fix uninitialized variable

Hi Alaa,

FYI: this patch has already been applied to the media_tree master git repo:

https://patchwork.linuxtv.org/project/linux-media/patch/2c46832a-99a8-73bf-ec85-085052f8b4db@xs4all.nl/

That's good enough for this issue so I am marking this patch as Obsolete in
our patchwork.

On 26/03/2021 22:02, Alaa Emad wrote:
> Reported-by: syzbot+a4e309017a5f3a24c7b3@...kaller.appspotmail.com
> Signed-off-by: Alaa Emad <alaaemadhossney.ae@...il.com>
> 
> ---
> Changes in v2:
>   - Fix the error occured because of pervious fix.
> ---
>  drivers/media/usb/gspca/sq905.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/usb/gspca/sq905.c b/drivers/media/usb/gspca/sq905.c
> index 97799cfb832e..57206dd2e1a0 100644
> --- a/drivers/media/usb/gspca/sq905.c
> +++ b/drivers/media/usb/gspca/sq905.c
> @@ -157,8 +157,8 @@ static int sq905_ack_frame(struct gspca_dev *gspca_dev)
>  static int
>  sq905_read_data(struct gspca_dev *gspca_dev, u8 *data, int size, int need_lock)
>  {
> -	int ret;
> -	int act_len;
> +	int ret;
> +	int act_len;
>  
>  	gspca_dev->usb_buf[0] = '\0';
>  	if (need_lock)
> @@ -180,8 +180,8 @@ sq905_read_data(struct gspca_dev *gspca_dev, u8 *data, int size, int need_lock)
>  			   data, size, &act_len, SQ905_DATA_TIMEOUT);
>  
>  	/* successful, it returns 0, otherwise  negative */
> -	if (ret < 0 || act_len != size) {
> -		pr_err("bulk read fail (%d) len %d/%d\n", ret, act_len, size);
> +	if (ret < 0 || act_len != size) {
> +	       pr_err("bulk read fail (%d) len %d/%d\n", ret, ret < 0 ? -1 : act_len, size);

General note: it looks like you are replacing tab characters with spaces.
Make sure you configure your editor not to do that.

Regards,

	Hans

>  		return -EIO;
>  	}
>  	return 0;
>