[<prev] [next>] [day] [month] [year] [list]
Message-ID: <22ba9fc3-11c6-bda4-d666-5d8b2f874349@huawei.com>
Date: Sat, 27 Mar 2021 17:58:29 +0800
From: Xiaofei Tan <tanxiaofei@...wei.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
CC: "rjw@...ysocki.net" <rjw@...ysocki.net>,
"lenb@...nel.org" <lenb@...nel.org>,
"rui.zhang@...el.com" <rui.zhang@...el.com>,
"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
"linuxarm@...neuler.org" <linuxarm@...neuler.org>,
Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v2 06/15] ACPI: LPSS: fix some coding style issues
Hi Andy,
On 2021/3/27 16:19, Andy Shevchenko wrote:
>
>
> On Saturday, March 27, 2021, Xiaofei Tan <tanxiaofei@...wei.com
> <mailto:tanxiaofei@...wei.com>> wrote:
>
> Fix some coding style issues reported by checkpatch.pl
> <http://checkpatch.pl>, including
> following types:
>
> WARNING: simple_strtol is obsolete, use kstrtol instead
>
>
> And one more thing, the above message is bogus. Read what the comments
> in the code says about use cases for simple_*() vs. kstrto*() ones.
>
OK. I would remove this modification from the patch.
> Joe?
>
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Xiaofei Tan <tanxiaofei@...wei.com
> <mailto:tanxiaofei@...wei.com>>
> ---
> drivers/acpi/acpi_lpss.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
> index be73974..2df231e 100644
> --- a/drivers/acpi/acpi_lpss.c
> +++ b/drivers/acpi/acpi_lpss.c
> @@ -187,7 +187,7 @@ static void byt_i2c_setup(struct
> lpss_private_data *pdata)
>
> /* Expected to always be true, but better safe then sorry */
> if (uid_str)
> - uid = simple_strtol(uid_str, NULL, 10);
> + uid = kstrtol(uid_str, NULL, 10);
>
> /* Detect I2C bus shared with PUNIT and ignore its d3 status */
> status = acpi_evaluate_integer(handle, "_SEM", NULL,
> &shared_host);
> @@ -377,6 +377,7 @@ static const struct acpi_device_id
> acpi_lpss_device_ids[] = {
> static int is_memory(struct acpi_resource *res, void *not_used)
> {
> struct resource r;
> +
> return !acpi_dev_resource_memory(res, &r);
> }
>
> @@ -1200,6 +1201,7 @@ static int acpi_lpss_poweroff_noirq(struct
> device *dev)
> if (pdata->dev_desc->resume_from_noirq) {
> /* This is analogous to the
> acpi_lpss_suspend_noirq() case. */
> int ret = acpi_lpss_do_poweroff_late(dev);
> +
> if (ret)
> return ret;
> }
> --
> 2.8.1
>
>
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
Powered by blists - more mailing lists