linux-kernel - Re: [Patch v3] usb: dwc3: add cancelled reasons for dwc3 requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 27 Mar 2021 14:35:27 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ray Chi <raychi@...gle.com>
Cc:     balbi@...nel.org, Thinh.Nguyen@...opsys.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        albertccwang@...gle.com
Subject: Re: [Patch v3] usb: dwc3: add cancelled reasons for dwc3 requests

On Sat, Mar 27, 2021 at 09:22:02PM +0800, Ray Chi wrote:
> Currently, when dwc3 handles request cancelled, dwc3 just returns
> -ECONNRESET for all requests. It will cause USB function drivers
> can't know if the requests are cancelled by other reasons.
> 
> This patch will replace DWC3_REQUEST_STATUS_CANCELLED with the
> reasons below.
>   - DWC3_REQUEST_STATUS_DISCONNECTED
>   - DWC3_REQUEST_STATUS_DEQUEUED
>   - DWC3_REQUEST_STATUS_STALLED
> 
> Signed-off-by: Ray Chi <raychi@...gle.com>
> ---
>  drivers/usb/dwc3/core.h   | 12 +++++++-----
>  drivers/usb/dwc3/gadget.c | 24 ++++++++++++++++++++----
>  drivers/usb/dwc3/gadget.h |  6 ++++--
>  3 files changed, 31 insertions(+), 11 deletions(-)

What changed from the previous versions?  that should always go below
the --- line as documented.

Please fix up and submit a v4 with that information.

thanks,

greg k-h