linux-kernel - Re: [PATCH 1/1] watchdog: dw_wdt: Remove duplicated header file inclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28b7616a-daa7-e944-8c0f-640eddaaebc8@roeck-us.net>
Date:   Sat, 27 Mar 2021 12:50:08 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Zhen Lei <thunder.leizhen@...wei.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-watchdog <linux-watchdog@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] watchdog: dw_wdt: Remove duplicated header file
 inclusion

On 3/26/21 6:20 PM, Zhen Lei wrote:
> The header file <linux/kernel.h> is already included above and can be
> removed here.
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>

Already submitted:

https://patchwork.kernel.org/project/linux-watchdog/patch/20210325112916.865510-1-wanjiabing@vivo.com/

In general, when removing duplicate or unnecessary header files,
please retain or improve alphabetic order. This patch makes it worse.

Guenter

> ---
>  drivers/watchdog/dw_wdt.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
> index 32d0e1781e63c4e..b1642e2d9175584 100644
> --- a/drivers/watchdog/dw_wdt.c
> +++ b/drivers/watchdog/dw_wdt.c
> @@ -19,7 +19,6 @@
>  #include <linux/delay.h>
>  #include <linux/err.h>
>  #include <linux/io.h>
> -#include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/moduleparam.h>
>  #include <linux/interrupt.h>
>