linux-kernel - Re: [PATCH 4/4] crypto: hisilicon/zip - support new 'sqe' type in Kunpeng930

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <833da1eb-0277-8466-23dc-15533eafbd8f@huawei.com>
Date:   Sat, 27 Mar 2021 10:59:49 +0800
From:   "shenyang (M)" <shenyang39@...wei.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     <davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
        <linux-crypto@...r.kernel.org>, <wangzhou1@...ilicon.com>
Subject: Re: [PATCH 4/4] crypto: hisilicon/zip - support new 'sqe' type in
 Kunpeng930



On 2021/3/26 17:14, Herbert Xu wrote:
> On Fri, Mar 19, 2021 at 03:33:07PM +0800, Yang Shen wrote:
>>
>> +const struct hisi_zip_sqe_ops hisi_zip_ops_v2 = {
>> +	.sqe_type		= 0x3,
>> +	.fill_addr		= hisi_zip_fill_addr,
>> +	.fill_buf_size		= hisi_zip_fill_buf_size,
>> +	.fill_buf_type		= hisi_zip_fill_buf_type,
>> +	.fill_req_type		= hisi_zip_fill_req_type,
>> +	.fill_tag		= hisi_zip_fill_tag_v2,
>> +	.fill_sqe_type		= hisi_zip_fill_sqe_type,
>> +	.get_tag		= hisi_zip_get_tag_v2,
>> +	.get_status		= hisi_zip_get_status,
>> +	.get_dstlen		= hisi_zip_get_dstlen,
>> +};
>> +
>
> This triggers a new warning:
>
>   CHECK   ../drivers/crypto/hisilicon/zip/zip_crypto.c
>   ../drivers/crypto/hisilicon/zip/zip_crypto.c:527:31: warning: symbol 'hisi_zip_ops_v1' was not declared. Should it be static?
>   ../drivers/crypto/hisilicon/zip/zip_crypto.c:540:31: warning: symbol 'hisi_zip_ops_v2' was not declared. Should it be static?
>
> Please fix.  Thanks.
>

Sorry， I'll fix this in next version.

Thanks.