[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210327221925.GA2875@duo.ucw.cz>
Date: Sat, 27 Mar 2021 23:19:25 +0100
From: Pavel Machek <pavel@....cz>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Robin van der Gracht <robin@...tonic.nl>,
Rob Herring <robh+dt@...nel.org>,
Miguel Ojeda <ojeda@...nel.org>,
Paul Burton <paulburton@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-leds <linux-leds@...r.kernel.org>,
Dan Murphy <dmurphy@...com>
Subject: Re: [PATCH 17/17] auxdisplay: ht16k33: Add segment display LED
support
Hi!
> > > > > - err = ht16k33_brightness_set(priv, MAX_BRIGHTNESS);
> > > > > + of_property_read_u32(node, "color", &color);
> > > > > + seg->led.name = devm_kasprintf(dev, GFP_KERNEL,
> > > > > + DRIVER_NAME ":%s:" LED_FUNCTION_BACKLIGHT,
> > > > > + color < LED_COLOR_ID_MAX ? led_colors[color] : "");
> >
> > And would prefer not to see driver_name as part of LED name.
>
> OK. So what should I use instead? Or just leave the part before the
> first colon empty?
I'd suggest auxdisplay:...:backlight.
And we should start documenting this somewhere.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)
Powered by blists - more mailing lists