linux-kernel - Re: [PATCH -next] arm64: smp: Add missing prototype for some smp.c functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210328172147.GA19252@arm.com>
Date:   Sun, 28 Mar 2021 18:21:48 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Chen Lifu <chenlifu@...wei.com>
Cc:     will@...nel.org, valentin.schneider@....com, maz@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        heying24@...wei.com, yuehaibing@...wei.com, weiyongjun1@...wei.com,
        johnny.chenyi@...wei.com
Subject: Re: [PATCH -next] arm64: smp: Add missing prototype for some smp.c
 functions

On Sat, Mar 27, 2021 at 03:06:51PM +0800, Chen Lifu wrote:
> In commit eb631bb5bf5b
> ("arm64: Support arch_irq_work_raise() via self IPIs") a new
> function "arch_irq_work_raise" was added without a prototype
> in header irq_work.h
> 
> In commit d914d4d49745
> ("arm64: Implement panic_smp_self_stop()") a new
> function "panic_smp_self_stop" was added without a prototype
> in header irq_work.h
> 
> We get the following warnings on W=1:
> arch/arm64/kernel/smp.c:842:6: warning: no previous prototype
> for ‘arch_irq_work_raise’ [-Wmissing-prototypes]
> arch/arm64/kernel/smp.c:862:6: warning: no previous prototype
> for ‘panic_smp_self_stop’ [-Wmissing-prototypes]
> 
> Fix the same by adding the missing prototype in header irq_work.h
> 
> Signed-off-by: Chen Lifu <chenlifu@...wei.com>
> ---
>  arch/arm64/include/asm/irq_work.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/include/asm/irq_work.h b/arch/arm64/include/asm/irq_work.h
> index a1020285ea75..f766e2190e7c 100644
> --- a/arch/arm64/include/asm/irq_work.h
> +++ b/arch/arm64/include/asm/irq_work.h
> @@ -2,6 +2,9 @@
>  #ifndef __ASM_IRQ_WORK_H
>  #define __ASM_IRQ_WORK_H
>  
> +extern void arch_irq_work_raise(void);
> +extern void panic_smp_self_stop(void);

The second prototype makes more sense in arch/arm64/include/asm/smp.h
where we already have crash_smp_send_stop().

-- 
Catalin