linux-kernel - [PATCH] drivers: iio: adc: fix unmet dependency on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 27 Mar 2021 23:51:59 -0400
From:   Julian Braha <julianbraha@...il.com>
To:     jic23@...nel.org
Cc:     fazilyildiran@...il.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] drivers: iio: adc: fix unmet dependency on OF

When AD9467 is enabled, and OF is disabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for ADI_AXI_ADC
 Depends on [n]: IIO [=y] && HAS_IOMEM [=y] && OF [=n]
 Selected by [y]:
 - AD9467 [=y] && IIO [=y] && SPI [=y]

This is because AD9467 selects ADI_AXI_ADC
without selecting or depending on OF,
despite ADI_AXI_ADC depending on OF.

Signed-off-by: Julian Braha <julianbraha@...il.com>
---
 drivers/iio/adc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index e0667c4b3c08..7606c9b1630e 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -248,7 +248,7 @@ config AD799X
 
 config AD9467
 	tristate "Analog Devices AD9467 High Speed ADC driver"
-	depends on SPI
+	depends on SPI && OF
 	select ADI_AXI_ADC
 	help
 	  Say yes here to build support for Analog Devices:
-- 
2.25.1