linux-kernel - Re: [PATCH 2/2] ASoC: amd: fix acpi dependency kernel warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4d5e624-d922-d338-ca35-72ee06cec08a@amd.com>
Date:   Sun, 28 Mar 2021 23:25:40 +0530
From:   "Mukunda,Vijendar" <vijendar.mukunda@....com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Mark Brown <broonie@...nel.org>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>,
        Alex Deucher <Alexander.Deucher@....com>,
        Basavaraj.Hiregoudar@....com, Sunil-kumar.Dommati@....com,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Ravulapati Vishnu vardhan rao 
        <Vishnuvardhanrao.Ravulapati@....com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] ASoC: amd: fix acpi dependency kernel warning



On 3/26/21 10:14 PM, Arnd Bergmann wrote:
> On Fri, Mar 26, 2021 at 5:44 PM Vijendar Mukunda
> <Vijendar.Mukunda@....com> wrote:
>>
>> Fix ACPI dependency kernel warning produced by powerpc
>> allyesconfig.
>>
>> sound/soc/amd/acp-da7219-max98357a.c:684:28: warning:
>> 'cz_rt5682_card' defined but not used [-Wunused-variable]
>>
>> sound/soc/amd/acp-da7219-max98357a.c:671:28: warning: 'cz_card'
>> defined but not used [-Wunused-variable]
> 
> I would suggest simply dropping the unnecessary #ifdef and
> ACPI_PTR() guard.
> 
> It might be helpful to hide the Kconfig submenu under
> 'depends on X86 || COMPILE_TEST'.
> 
>         Arnd
> 

Will drop the unnecessary safegaurd and will upload the new version.