linux-kernel - Re: [PATCH v2 1/3] iommu: io-pgtable: add DART pagetable format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2ea0e787-6d00-4412-841d-529e1409eb05@www.fastmail.com>
Date:   Sun, 28 Mar 2021 12:13:46 +0200
From:   "Sven Peter" <sven@...npeter.dev>
To:     "kernel test robot" <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org, "Will Deacon" <will@...nel.org>,
        "Robin Murphy" <robin.murphy@....com>,
        "Joerg Roedel" <joro@...tes.org>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Arnd Bergmann" <arnd@...nel.org>, devicetree@...r.kernel.org,
        "Hector Martin" <marcan@...can.st>, linux-kernel@...r.kernel.org,
        "Marc Zyngier" <maz@...nel.org>
Subject: Re: [PATCH v2 1/3] iommu: io-pgtable: add DART pagetable format

Hi,

On Sun, Mar 28, 2021, at 11:42, kernel test robot wrote:
> 
> All errors (new ones prefixed by >>):
> 
> >> nios2-linux-ld: drivers/iommu/io-pgtable.o:(.rodata+0x1c): undefined reference to `io_pgtable_apple_dart_init_fns'
> 
>

That one was me not being careful enough when removing the Kconfig flag
compared to v1.

Fixed by moving

	[ARM_APPLE_DART] = &io_pgtable_apple_dart_init_fns,

into the #ifdef CONFIG_IOMMU_IO_PGTABLE_LPAE region in drivers/iommu/io-pgtable.c
a few lines above.


Thanks,

Sven