linux-kernel - Re: [PATCH v2 8/8] pinctrl: stm32: Add STM32H750 MCU pinctrl support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e342f4e2-161c-e277-c88c-d51d49187b93@foss.st.com>
Date:   Mon, 29 Mar 2021 12:13:17 +0200
From:   Alexandre TORGUE <alexandre.torgue@...s.st.com>
To:     dillon min <dillon.minfei@...il.com>
CC:     Rob Herring <robh+dt@...nel.org>,
        Ahmad Fatoum <a.fatoum@...gutronix.de>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        <linux@...linux.org.uk>, Vladimir Murzin <vladimir.murzin@....com>,
        <afzal.mohd.ma@...il.com>
Subject: Re: [PATCH v2 8/8] pinctrl: stm32: Add STM32H750 MCU pinctrl support



On 3/29/21 10:07 AM, dillon min wrote:
> On Mon, Mar 29, 2021 at 4:00 PM Alexandre TORGUE
> <alexandre.torgue@...s.st.com> wrote:
>>
>> Hi Dillon
>>
>> On 3/12/21 7:24 AM, dillon.minfei@...il.com wrote:
>>> From: dillon min <dillon.minfei@...il.com>
>>>
>>> This patch adds STM32H750 pinctrl and GPIO support
>>> since stm32h750 has the same pin alternate functions
>>> with stm32h743, so just reuse the stm32h743's pinctrl
>>> driver
>>>
>>> Signed-off-by: dillon min <dillon.minfei@...il.com>
>>> ---
>>> v2:
>>> - add compatible string st,stm32h750-pinctrl to pinctl-stm32h743.c as they
>>>     have same pin alternate functions
>>> - add STM32H750 to Kconfig description
>>>
>>>    drivers/pinctrl/stm32/Kconfig             | 2 +-
>>>    drivers/pinctrl/stm32/pinctrl-stm32h743.c | 3 +++
>>>    2 files changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig
>>> index f36f29113370..fb1ffc94c57f 100644
>>> --- a/drivers/pinctrl/stm32/Kconfig
>>> +++ b/drivers/pinctrl/stm32/Kconfig
>>> @@ -35,7 +35,7 @@ config PINCTRL_STM32F769
>>>        select PINCTRL_STM32
>>>
>>>    config PINCTRL_STM32H743
>>> -     bool "STMicroelectronics STM32H743 pin control" if COMPILE_TEST && !MACH_STM32H743
>>> +     bool "STMicroelectronics STM32H743/STM32H750 pin control" if COMPILE_TEST && !MACH_STM32H743
>>>        depends on OF && HAS_IOMEM
>>>        default MACH_STM32H743
>>>        select PINCTRL_STM32
>>> diff --git a/drivers/pinctrl/stm32/pinctrl-stm32h743.c b/drivers/pinctrl/stm32/pinctrl-stm32h743.c
>>> index ffe7b5271506..700206c7bc11 100644
>>> --- a/drivers/pinctrl/stm32/pinctrl-stm32h743.c
>>> +++ b/drivers/pinctrl/stm32/pinctrl-stm32h743.c
>>> @@ -1966,6 +1966,9 @@ static const struct of_device_id stm32h743_pctrl_match[] = {
>>>                .compatible = "st,stm32h743-pinctrl",
>>>                .data = &stm32h743_match_data,
>>>        },
>>> +     {       .compatible = "st,stm32h750-pinctrl",
>>> +             .data = &stm32h743_match_data,
>>> +     },
>>
>> If you use exactly the same driver (i.e. same ball out and AF mux) then
>> you don't have to create a new compatible for that. Just use the same
>> than h743.(so you don't have to factorize DT files).
> Okay, yes they are the total same ball out and AF mux. I will delete
> it in the next submission.
>   Just a kindly reminder , the newest version of this patchset is [PATCH v6].

Yes I'm late :)

> 
> Thanks.
>>
>> Regards
>> Alex
>>
>>>        { }
>>>    };
>>>
>>>