linux-kernel - Re: [PATCH v3 3/3] iio: adc: add ADC driver for the TI TSC2046 controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210329112347.6a42628f@jic23-huawei>
Date:   Mon, 29 Mar 2021 11:23:47 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        devicetree@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org,
        Robin van der Gracht <robin@...tonic.nl>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-kernel@...r.kernel.org,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        David Jander <david@...tonic.nl>
Subject: Re: [PATCH v3 3/3] iio: adc: add ADC driver for the TI TSC2046
 controller

On Mon, 29 Mar 2021 09:38:38 +0200
Oleksij Rempel <o.rempel@...gutronix.de> wrote:

> On Mon, Mar 22, 2021 at 02:27:22PM +0000, Jonathan Cameron wrote:
> > > > > +static DECLARE_TI_TSC2046_8_CHANNELS(tsc2046_adc, 12);
> > > > > +
> > > > > +static const struct tsc2046_adc_dcfg tsc2046_adc_dcfg_tsc2046e = {
> > > > > +	.channels = tsc2046_adc_channels,
> > > > > +	.num_channels = ARRAY_SIZE(tsc2046_adc_channels),
> > > > > +};
> > > > > +    
> > > > 
> > > > Hmm.  Flexibility that isn't yet used.  Normally I'm pretty resistant
> > > > to this going in, unless I'm reassured that there is support for additional
> > > > devices already in the pipeline.  Is that true here?  Otherwise
> > > > this is basically unneeded complexity.    
> > > 
> > > In the long term this driver should replace
> > > drivers/input/touchscreen/ads7846.c
> > > 
> > > This driver supports ti,ads7843, ti,ads7845, ti,ads7846.. at least with
> > > following number of supported channels:
> > > ti,ads7843 - 4 channels: x, y, aux0, aux1
> > > ti,ads7845 - 3 channels: x, y, aux0
> > > ti,ads7846 - 8 channels...
> > > 
> > > Currently I don't have this HW for testing and there a subtle
> > > differences that have to be taken care of and tested.
> > >   
> > 
> > Note that I'm only going to merge this driver with an explicit statement
> > from Dmitry as input maintainer that he is fine with this approach.  
> 
> Since there is still no Dmitry's feedback please take a look to the
> ti,ads7843 datasheet:
> https://www.ti.com/lit/ds/symlink/ads7843.pdf
> 
> On the page 1 you can see, that this device has two general purpose ADC
> inputs IN3, IN4. If some one will decide to mainline support for this
> pins, will end with IIO ADC driver any way :)

Understood, but I'm still going to want Dmitry to give an opinion on
this.  That might take a little while though as he may well be busy!

Jonathan

> 
> Regards,
> Oleksij