linux-kernel - Re: [PATCH v9 4/4] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YGGunNguZTiRS8FP@kroah.com>
Date:   Mon, 29 Mar 2021 12:40:28 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Gustavo Pimentel <Gustavo.Pimentel@...opsys.com>
Cc:     "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Derek Kiernan <derek.kiernan@...inx.com>,
        Dragan Cvetic <dragan.cvetic@...inx.com>,
        Arnd Bergmann <arnd@...db.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jonathan Corbet <corbet@....net>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Krzysztof Wilczyński <kw@...ux.com>
Subject: Re: [PATCH v9 4/4] docs: ABI: Add sysfs documentation interface of
 dw-xdata-pcie driver

On Mon, Mar 29, 2021 at 10:25:25AM +0000, Gustavo Pimentel wrote:
> On Mon, Mar 29, 2021 at 11:8:11, Greg Kroah-Hartman 
> <gregkh@...uxfoundation.org> wrote:
> 
> > On Mon, Mar 29, 2021 at 11:59:40AM +0200, Gustavo Pimentel wrote:
> > > This patch describes the sysfs interface implemented on the dw-xdata-pcie
> > > driver.
> > > 
> > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@...opsys.com>
> > > ---
> > >  Documentation/ABI/testing/sysfs-driver-xdata | 46 ++++++++++++++++++++++++++++
> > >  1 file changed, 46 insertions(+)
> > >  create mode 100644 Documentation/ABI/testing/sysfs-driver-xdata
> > > 
> > > diff --git a/Documentation/ABI/testing/sysfs-driver-xdata b/Documentation/ABI/testing/sysfs-driver-xdata
> > > new file mode 100644
> > > index 00000000..66af19a
> > > --- /dev/null
> > > +++ b/Documentation/ABI/testing/sysfs-driver-xdata
> > > @@ -0,0 +1,46 @@
> > > +What:		/sys/class/misc/drivers/dw-xdata-pcie.<device>/write
> > > +Date:		April 2021
> > > +KernelVersion:	5.13
> > > +Contact:	Gustavo Pimentel <gustavo.pimentel@...opsys.com>
> > > +Description:	Allows the user to enable the PCIe traffic generator which
> > > +		will create write TLPs frames - from the Root Complex to the
> > > +		Endpoint direction.
> > > +		Usage e.g.
> > > +		 echo 1 > /sys/class/misc/dw-xdata-pcie.<device>/write
> > 
> > Again, this does not match the code.  Either fix the code (which I
> > recommend), or change this and the other sysfs descriptions of writing
> > values here.
> 
> I've commented about this previously, but I didn't get feedback on it, 
> therefore I assumed that justification was okay.
> I will change the code to accept only the "1" input on the *_store()

Why not use the built-in function to parse "1/y/Y" that the kernel
provides for this type of thing?

thanks,

greg k-h