linux-kernel - Re: [PATCH] drivers: iio: adc: fix unmet dependency on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Mar 2021 14:18:12 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Alexandru Ardelean <ardeleanalex@...il.com>
Cc:     Julian Braha <julianbraha@...il.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Necip Fazil Yildiran <fazilyildiran@...il.com>,
        linux-iio <linux-iio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: iio: adc: fix unmet dependency on OF

On Mon, Mar 29, 2021 at 9:43 AM Alexandru Ardelean
<ardeleanalex@...il.com> wrote:
> On Sun, Mar 28, 2021 at 7:08 AM Julian Braha <julianbraha@...il.com> wrote:
> >
> > When AD9467 is enabled, and OF is disabled,
> > Kbuild gives the following warning:
> >
> > WARNING: unmet direct dependencies detected for ADI_AXI_ADC
> >  Depends on [n]: IIO [=y] && HAS_IOMEM [=y] && OF [=n]
> >  Selected by [y]:
> >  - AD9467 [=y] && IIO [=y] && SPI [=y]
> >
> > This is because AD9467 selects ADI_AXI_ADC
> > without selecting or depending on OF,
> > despite ADI_AXI_ADC depending on OF.

> Thanks for the patch.
> This should have been fixed a bit differently with patch:
> https://patchwork.kernel.org/project/linux-iio/patch/20210324182746.9337-1-aardelean@deviqon.com/
>
> Can you check if this fixes your setup?

I have to add for sake of the clarification that we are trying really
hard to make drivers agnostic to the device tree provider. In such a
case the same driver can work for all existing providers (ACPI, DT,
and board files with use of software nodes).

-- 
With Best Regards,
Andy Shevchenko