linux-kernel - Re: [PATCH] ALSA: core: remove redundant spin_lock pair in snd_card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 29 Mar 2021 13:26:29 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     root <wang.yi59@....com.cn>
Cc:     perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, xue.zhihong@....com.cn,
        wang.liang82@....com.cn, Jia Zhou <zhou.jia2@....com.cn>
Subject: Re: [PATCH] ALSA: core: remove redundant spin_lock pair in snd_card_disconnect

On Mon, 29 Mar 2021 05:36:47 +0200,
root wrote:
> 
> [1.1.1  <text/plain; UTF-8 (base64)>]
> 
> From: Jia Zhou <zhou.jia2@....com.cn>
> 
> modification in commit 2a3f7221acdd ("ALSA: core: Fix card races between
> register and disconnect") resulting in this problem.
> 
> Signed-off-by: Jia Zhou <zhou.jia2@....com.cn>
> Signed-off-by: Yi Wang <wang.yi59@....com.cn>

The code change looks good, but the patch isn't cleanly applicable via
git-am.  Could you fix your MUA setup, or try to submit via
git-send-email?


thanks,

Takashi

> ---
>  sound/core/init.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/sound/core/init.c b/sound/core/init.c
> index 018ce4ef1..9f5270c90 100644
> --- a/sound/core/init.c
> +++ b/sound/core/init.c
> @@ -390,10 +390,8 @@ int snd_card_disconnect(struct snd_card *card)
>          return 0;
>      }
>      card->shutdown = 1;
> -    spin_unlock(&card->files_lock);
>  
>      /* replace file->f_op with special dummy operations */
> -    spin_lock(&card->files_lock);
>      list_for_each_entry(mfile, &card->files_list, list) {
>          /* it's critical part, use endless loop */
>          /* we have no room to fail */
> -- 
> 2.18.4
> 
>