[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210329122708.010a36a9@jic23-huawei>
Date: Mon, 29 Mar 2021 12:27:08 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Lee Jones <lee.jones@...aro.org>
Cc: linux-kernel@...r.kernel.org, Jiri Kosina <jikos@...nel.org>,
Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
Benjamin Tissoires <benjamin.tissoires@...hat.com>,
linux-input@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH 22/25] HID: hid-sensor-hub: Remove unused struct member
'quirks'
On Fri, 26 Mar 2021 14:34:55 +0000
Lee Jones <lee.jones@...aro.org> wrote:
> Commit b0f847e16c1ea ("HID: hid-sensor-hub: Force logical minimum to 1
> for power and report state") removed the last used quirk handled by
> this driver.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/hid/hid-sensor-hub.c:39: warning: Function parameter or member 'quirks' not described in 'sensor_hub_data'
>
> Cc: Jiri Kosina <jikos@...nel.org>
> Cc: Jonathan Cameron <jic23@...nel.org>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> Cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> Cc: linux-input@...r.kernel.org
> Cc: linux-iio@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> ---
> drivers/hid/hid-sensor-hub.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
> index 3dd7d32467378..36b6852f75dd5 100644
> --- a/drivers/hid/hid-sensor-hub.c
> +++ b/drivers/hid/hid-sensor-hub.c
> @@ -34,7 +34,6 @@ struct sensor_hub_data {
> spinlock_t dyn_callback_lock;
> struct mfd_cell *hid_sensor_hub_client_devs;
> int hid_sensor_client_cnt;
> - unsigned long quirks;
> int ref_cnt;
> };
>
> @@ -615,7 +614,6 @@ static int sensor_hub_probe(struct hid_device *hdev,
> }
>
> hid_set_drvdata(hdev, sd);
> - sd->quirks = id->driver_data;
>
> spin_lock_init(&sd->lock);
> spin_lock_init(&sd->dyn_callback_lock);
Powered by blists - more mailing lists