linux-kernel - Re: [PATCH 1/3] ARM: dts: imx6: pfla02: Fix USB vbus enable pinmuxing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b449e9c40d225b3dbec9c79435b856f89ccdde29.camel@phytec.de>
Date:   Mon, 29 Mar 2021 12:39:37 +0000
From:   Stefan Riedmüller <S.Riedmueller@...tec.de>
To:     "festevam@...il.com" <festevam@...il.com>
CC:     "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "linux-imx@....com" <linux-imx@....com>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
Subject: Re: [PATCH 1/3] ARM: dts: imx6: pfla02: Fix USB vbus enable pinmuxing

Hi Fabio,

On Mon, 2021-03-29 at 08:32 -0300, Fabio Estevam wrote:
> Hi Stefan,
> 
> On Mon, Mar 29, 2021 at 8:28 AM Stefan Riedmueller
> <s.riedmueller@...tec.de> wrote:
> 
> > -               pinctrl_usbh1: usbh1grp {
> > +               pinctrl_usbh1_vbus: usbh1vbusgrp {
> >                         fsl,pins = <
> > -                               MX6QDL_PAD_GPIO_0__USB_H1_PWR           0x
> > 80000000
> > +                               MX6QDL_PAD_GPIO_0__GPIO1_IO00           0x
> > 80000000
> 
> While you are on it, could you please use avoid the usage of
> 0x80000000 and explicitly pass the default value instead?

Thanks for your review. Sure, I'll fix that in a v2.

Stefan