linux-kernel - Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3043284c440c703ab3c4deaf77b6e81670d571e2.camel@toradex.com>
Date:   Mon, 29 Mar 2021 00:49:04 +0000
From:   Marcel Ziswiler <marcel.ziswiler@...adex.com>
To:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "victor.liu@....com" <victor.liu@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>
CC:     "linux-imx@....com" <linux-imx@....com>,
        "narmstrong@...libre.com" <narmstrong@...libre.com>,
        "Laurent.pinchart@...asonboard.com" 
        <Laurent.pinchart@...asonboard.com>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "a.hajda@...sung.com" <a.hajda@...sung.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "jonas@...boo.se" <jonas@...boo.se>,
        "kishon@...com" <kishon@...com>,
        "robert.foss@...aro.org" <robert.foss@...aro.org>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "festevam@...il.com" <festevam@...il.com>,
        "jernej.skrabec@...l.net" <jernej.skrabec@...l.net>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>
Subject: Re: [PATCH v6 00/14] Add some DRM bridge drivers support for
 i.MX8qm/qxp SoCs

Hi Liu

On Tue, 2021-03-23 at 17:09 +0800, Liu Ying wrote:
> On Tue, 2021-03-23 at 01:03 +0000, Marcel Ziswiler wrote:
> > Hi Liu
> > 
> > Some further discrepancy with them binding examples:
> > 
> > arch/arm64/boot/dts/freescale/imx8qxp.dtsi:335.9-36: Warning (reg_format): /dpu@...80000:reg: property has
> > invalid length (8 bytes) (#address-cells == 2, #size-cells == 2)
> > arch/arm64/boot/dts/freescale/imx8qxp.dtsi:508.9-35: Warning (reg_format): /syscon@...21000:reg: property has
> > invalid length (8 bytes) (#address-cells == 2, #size-cells == 2)
> > arch/arm64/boot/dts/freescale/imx8qxp.dtsi:601.9-34: Warning (reg_format): /phy@...28300:reg: property has
> > invalid length (8 bytes) (#address-cells == 2, #size-cells == 2)
> > arch/arm64/boot/dts/freescale/imx8qxp.dtsi:613.9-36: Warning (reg_format): /pixel-combiner@...20000:reg:
> > property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 2)
> > 
> > And with that I am unable to bring it up:
> > 
> > [    1.714498] imx8qxp-ldb 5622100000001000.syscon:ldb: [drm:ldb_init_helper] *ERROR* failed to get regmap: -
> > 12
> > [    1.724441] imx8qxp-ldb: probe of 5622100000001000.syscon:ldb failed with error -12
> > [    1.734983] imx8qxp-pixel-combiner 5602000000010000.pixel-combiner: invalid resource
> > [    1.742830] imx8qxp-pixel-combiner: probe of 5602000000010000.pixel-combiner failed with error -22
> > [    1.754040] imx8qxp-display-pixel-link dc0-pixel-link0: [drm:imx8qxp_pixel_link_bridge_probe] *ERROR*
> > failed
> > to get pixel link node alias id: -19
> > [    1.769626] imx8qxp-pxl2dpi 5622100000001000.syscon:pxl2dpi: [drm:imx8qxp_pxl2dpi_bridge_probe] *ERROR*
> > failed to get regmap: -12
> > [    1.781397] imx8qxp-pxl2dpi: probe of 5622100000001000.syscon:pxl2dpi failed with error -12
> > [    1.840547] imx8qxp-lpcg-clk 59580000.clock-controller: deferred probe timeout, ignoring dependency
> > [    1.840571] imx8qxp-lpcg-clk: probe of 59580000.clock-controller failed with error -110
> > 
> > Any suggestions welcome. Thanks!
> 
> Please reference the patch set I shared in my last reply and see how it
> goes.  Thanks.

Thank you very much. After a little bit of fiddling I can confirm that this also works fine on a Toradex
Colibri iMX8X [1] with either a Capacitive Touch Display 10.1" LVDS which has a Logic Technologies LT170410-
2WHC [2] single-channel panel inside or a dual-channel LG LP156WF1 full HD panel.

During boot I noticed quite some clocking/power domain related messages:

[    0.537965] gpt0_clk: failed to attached the power domain -2

[    0.562372] dc1_disp0_clk: failed to attached the power domain -2
[    0.562800] dc1_disp0_clk: failed to get clock parent -22
[    0.562858] dc1_disp0_clk: failed to get clock rate -22

[    0.563059] dc1_disp1_clk: failed to attached the power domain -2
[    0.563463] dc1_disp1_clk: failed to get clock parent -22
[    0.563514] dc1_disp1_clk: failed to get clock rate -22

[    0.563773] dc1_pll0_clk: failed to attached the power domain -2
[    0.564174] dc1_pll0_clk: failed to get clock rate -22

[    0.564413] dc1_pll1_clk: failed to attached the power domain -2
[    0.564838] dc1_pll1_clk: failed to get clock rate -22

[    0.565099] dc1_bypass0_clk: failed to attached the power domain -2
[    0.565516] dc1_bypass0_clk: failed to get clock rate -22

[    0.565755] dc1_bypass1_clk: failed to attached the power domain -2
[    0.566159] dc1_bypass1_clk: failed to get clock rate -22

[    0.574493] lvds0_i2c0_clk: failed to attached the power domain -2
[    0.574894] lvds0_i2c0_clk: failed to get clock rate -22

[    0.575134] lvds0_i2c1_clk: failed to attached the power domain -2
[    0.575526] lvds0_i2c1_clk: failed to get clock rate -22

[    0.575785] lvds0_pwm0_clk: failed to attached the power domain -2
[    0.576189] lvds0_pwm0_clk: failed to get clock rate -22

[    0.576417] lvds1_i2c0_clk: failed to attached the power domain -2
[    0.576854] lvds1_i2c0_clk: failed to get clock rate -22

[    0.577129] lvds1_i2c1_clk: failed to attached the power domain -2
[    0.577554] lvds1_i2c1_clk: failed to get clock rate -22

[    0.577787] lvds1_pwm0_clk: failed to attached the power domain -2
[    0.578198] lvds1_pwm0_clk: failed to get clock rate -22

[    0.578464] mipi_csi0_core_clk: failed to attached the power domain -2

[    0.579104] mipi_csi0_esc_clk: failed to attached the power domain -2

[    0.579738] mipi_csi0_i2c0_clk: failed to attached the power domain -2

[    0.580368] mipi_csi0_pwm0_clk: failed to attached the power domain -2

And the following repeats a couple dozens of times:

[    4.391495] dc1_disp0_clk: failed to get clock parent -22
[    4.398532] dc1_disp1_clk: failed to get clock parent -22

And finally it spits the following:

[    4.670303] imx8qxp-lpcg-clk 59580000.clock-controller: deferred probe timeout, ignoring dependency
[    4.679629] imx8qxp-lpcg-clk: probe of 59580000.clock-controller failed with error -110

Despite those messages the displays do work fine once booted.

I am currently running this with SCFW, SECO, TF-A and U-Boot based off NXP's latest downstream BSP 5.4.70-
2.3.0. Not sure whether or not especially the used SCFW version could cause some issues. What SCFW are you
using?

Full boot logs may be found here [3].

You may add the following to the whole series.

Tested-by: Marcel Ziswiler <marcel.ziswiler@...adex.com> # Colibri iMX8X, LT170410-2WHC, LP156WF1

Thanks again and just let us know if we may test anything else for you.

[1] commit ba5a5615d54f ("arm64: dts: freescale: add initial support for colibri imx8x")
[2] commit 5728fe7fa539 ("drm/panel: simple: add display timings for logic technologies displays")
[3] https://share.toradex.com/s30wwspcr9iwyrg

> Liu Ying

Cheers

Marcel