linux-kernel - Re: [PATCH v5 08/13] arm64: dts: mediatek: mt8516: harmonize node names and compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff4ab27b-5a76-0597-780c-7b101e1b0963@gmail.com>
Date:   Mon, 29 Mar 2021 15:46:55 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Vinod Koul <vkoul@...nel.org>, Rob Herring <robh+dt@...nel.org>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Jie Qiu <jie.qiu@...iatek.com>, CK Hu <ck.hu@...iatek.com>,
        Cawa Cheng <cawa.cheng@...iatek.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v5 08/13] arm64: dts: mediatek: mt8516: harmonize node
 names and compatibles



On 16/03/2021 10:22, Chunfeng Yun wrote:
> This is used to fix dtbs_check warning:
>   harmonize node names and compatibles;
>   add property "usb-role-switch" for connector dependence.
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>

Applied now to v5.12-next/dts64

> ---
> v2~v5: no changes
> ---
>  arch/arm64/boot/dts/mediatek/mt8516.dtsi         | 9 +++++----
>  arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi | 1 +
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> index b80e95574bef..bbe5a1419eff 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> @@ -480,7 +480,7 @@
>  		};
>  
>  		usb0: usb@...00000 {
> -			compatible = "mediatek,mtk-musb";
> +			compatible = "mediatek,mt8516-musb", "mediatek,mtk-musb";
>  			reg = <0 0x11100000 0 0x1000>;
>  			interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_LOW>;
>  			interrupt-names = "mc";
> @@ -493,7 +493,7 @@
>  		};
>  
>  		usb1: usb@...90000 {
> -			compatible = "mediatek,mtk-musb";
> +			compatible = "mediatek,mt8516-musb", "mediatek,mtk-musb";
>  			reg = <0 0x11190000 0 0x1000>;
>  			interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_LOW>;
>  			interrupt-names = "mc";
> @@ -506,8 +506,9 @@
>  			status = "disabled";
>  		};
>  
> -		usb_phy: usb@...10000 {
> -			compatible = "mediatek,generic-tphy-v1";
> +		usb_phy: t-phy@...10000 {
> +			compatible = "mediatek,mt8516-tphy",
> +				     "mediatek,generic-tphy-v1";
>  			reg = <0 0x11110000 0 0x800>;
>  			#address-cells = <2>;
>  			#size-cells = <2>;
> diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> index 63fd70086bb8..7d738f01cf8d 100644
> --- a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> @@ -188,6 +188,7 @@
>  &usb0 {
>  	status = "okay";
>  	dr_mode = "peripheral";
> +	usb-role-switch;
>  
>  	usb_con: connector {
>  		compatible = "usb-c-connector";
>