linux-kernel - Re: [PATCH mvebu v3 08/10] cpufreq: armada-37xx: Fix determining base CPU frequency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pmzidmzs.fsf@BL-laptop>
Date:   Mon, 29 Mar 2021 16:59:35 +0200
From:   Gregory CLEMENT <gregory.clement@...tlin.com>
To:     Pali Rohár <pali@...nel.org>,
        Andrew Lunn <andrew@...n.ch>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org
Cc:     Marek Behún <kabel@...nel.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Tomasz Maciej Nowak <tmn505@...il.com>,
        Luka Perkov <luka.perkov@...tura.hr>,
        Andre Heider <a.heider@...il.com>,
        Vladimir Vid <vladimir.vid@...tura.hr>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Gérald Kerma <gerald@....net>,
        Konstantin Porotchkin <kostap@...vell.com>
Subject: Re: [PATCH mvebu v3 08/10] cpufreq: armada-37xx: Fix determining
 base CPU frequency

Pali Rohár <pali@...nel.org> writes:

> When current CPU load is not L0 then loading armada-37xx-cpufreq.ko driver
> fails with following error:
>
>     # modprobe armada-37xx-cpufreq
>     [  502.702097] Unsupported CPU frequency 250 MHz
>
> This issue was partially fixed by commit 8db82563451f ("cpufreq:
> armada-37xx: fix frequency calculation for opp"), but only for calculating
> CPU frequency for opp.
>
> Fix this also for determination of base CPU frequency.
>
> Signed-off-by: Pali Rohár <pali@...nel.org>
> Tested-by: Tomasz Maciej Nowak <tmn505@...il.com>
> Tested-by: Anders Trier Olesen <anders.trier.olesen@...il.com>
> Tested-by: Philip Soares <philips@...isense.com>
> Fixes: 92ce45fb875d ("cpufreq: Add DVFS support for Armada 37xx")
> Cc: stable@...r.kernel.org # 8db82563451f ("cpufreq: armada-37xx: fix
> frequency calculation for opp")

Acked-by: Gregory CLEMENT <gregory.clement@...tlin.com>

Thanks,

Gregory

> ---
>  drivers/cpufreq/armada-37xx-cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/armada-37xx-cpufreq.c b/drivers/cpufreq/armada-37xx-cpufreq.c
> index 1ab2113daef5..e4782f562e7a 100644
> --- a/drivers/cpufreq/armada-37xx-cpufreq.c
> +++ b/drivers/cpufreq/armada-37xx-cpufreq.c
> @@ -469,7 +469,7 @@ static int __init armada37xx_cpufreq_driver_init(void)
>  		return -EINVAL;
>  	}
>  
> -	dvfs = armada_37xx_cpu_freq_info_get(cur_frequency);
> +	dvfs = armada_37xx_cpu_freq_info_get(base_frequency);
>  	if (!dvfs) {
>  		clk_put(clk);
>  		return -EINVAL;
> -- 
> 2.20.1
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com