linux-kernel - Re: [PATCH v5 0/5] KVM: x86: dump_vmcs: don't assume GUEST_IA32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cunsg4dhl94.fsf@oracle.com>
Date:   Mon, 29 Mar 2021 19:23:35 +0100
From:   David Edmondson <david.edmondson@...cle.com>
To:     linux-kernel@...r.kernel.org
Cc:     Ingo Molnar <mingo@...hat.com>, Joerg Roedel <joro@...tes.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org,
        Wanpeng Li <wanpengli@...cent.com>, x86@...nel.org,
        Borislav Petkov <bp@...en8.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Sean Christopherson <seanjc@...gle.com>,
        Jim Mattson <jmattson@...gle.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>
Subject: Re: [PATCH v5 0/5] KVM: x86: dump_vmcs: don't assume
 GUEST_IA32_EFER, show MSR autoloads/autosaves

On Thursday, 2021-03-18 at 12:08:36 GMT, David Edmondson wrote:

> v2:
> - Don't use vcpu->arch.efer when GUEST_IA32_EFER is not available (Paolo).
> - Dump the MSR autoload/autosave lists (Paolo).
>
> v3:
> - Rebase to master.
> - Check only the load controls (Sean).
> - Always show the PTPRs from the VMCS if they exist (Jim/Sean).
> - Dig EFER out of the MSR autoload list if it's there (Paulo).
> - Calculate and show the effective EFER if it is not coming from
>   either the VMCS or the MSR autoload list (Sean).
>
> v4:
> - Ensure that each changeset builds with just the previous set.
>
> v5:
> - Rebase.
> - Remove some cruft from changeset comments.
> - Add S-by as appropriate.

Any further comments or suggestions?

Thanks.

> David Edmondson (5):
>   KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid
>   KVM: x86: dump_vmcs should not conflate EFER and PAT presence in VMCS
>   KVM: x86: dump_vmcs should consider only the load controls of EFER/PAT
>   KVM: x86: dump_vmcs should show the effective EFER
>   KVM: x86: dump_vmcs should include the autoload/autostore MSR lists
>
>  arch/x86/kvm/vmx/vmx.c | 58 +++++++++++++++++++++++++++++-------------
>  arch/x86/kvm/vmx/vmx.h |  2 +-
>  2 files changed, 42 insertions(+), 18 deletions(-)
>
> -- 
> 2.30.2

dme.
-- 
Everybody's got something to hide, 'cept me and my monkey.